[PATCH v3 2/5] pinctrl: samsung: fix incorrect pin-bank entries on Exynos2200/7885/8890/8895

[남영민]

Hi Alim

> -----Original Message-----
> From: Alim Akhtar <alim.akhtar at samsung.com>
> Sent: Monday, June 29, 2026 6:23 PM
> To: 'Peter Griffin' <peter.griffin at linaro.org>; 'Youngmin Nam'
> <youngmin.nam at samsung.com>
> Cc: krzk at kernel.org; s.nawrocki at samsung.com; linus.walleij at linaro.org;
> semen.protsenko at linaro.org; ivo.ivanov.ivanov1 at gmail.com;
> ryu.real at samsung.com; d7271.choe at samsung.com; shin.son at samsung.com;
> jaewon02.kim at samsung.com; linux-arm-kernel at lists.infradead.org; linux-
> samsung-soc at vger.kernel.org; linux-gpio at vger.kernel.org; linux-
> kernel at vger.kernel.org
> Subject: RE: [PATCH v3 2/5] pinctrl: samsung: fix incorrect pin-bank
> entries on Exynos2200/7885/8890/8895
> 
> Hi Krzysztof, Peter
> 
> > -----Original Message-----
> > From: Peter Griffin <peter.griffin at linaro.org>
> > Sent: Saturday, March 7, 2026 2:47 AM
> > To: Youngmin Nam <youngmin.nam at samsung.com>
> > Cc: krzk at kernel.org; s.nawrocki at samsung.com; alim.akhtar at samsung.com;
> > linus.walleij at linaro.org; semen.protsenko at linaro.org;
> > ivo.ivanov.ivanov1 at gmail.com; ryu.real at samsung.com;
> > d7271.choe at samsung.com; shin.son at samsung.com;
> > jaewon02.kim at samsung.com; linux-arm-kernel at lists.infradead.org; linux-
> > samsung-soc at vger.kernel.org; linux-gpio at vger.kernel.org; linux-
> > kernel at vger.kernel.org
> > Subject: Re: [PATCH v3 2/5] pinctrl: samsung: fix incorrect pin-bank
> > entries on
> > Exynos2200/7885/8890/8895
> >
> > Hi Youngmin,
> >
> > On Tue, 2 Dec 2025 at 09:30, Youngmin Nam <youngmin.nam at samsung.com>
> > wrote:
> > >
> > > This patch corrects wrong pin bank table definitions for 4 SoCs
> > > based on their TRMs.
> > >
> > > Exynos2200
> > > - gpq0/1/2 were using EXYNOS_PIN_BANK_EINTN(), which implies a
> > >   'bank_type_off' layout (.fld_width = {4,1,2,2,2,2}).
> > > - Per the SoC TRM these banks must use the 'alive' layout
> > >   (.fld_width = {4,1,4,4}).
> > > - Switch them to
> > EXYNOS9_PIN_BANK_EINTN(exynos9_bank_type_alive, ...).
> > >
> > > Exynos7885
> > > - etc0, etc1: update bank type to match the SoC TRM.
> > > - gpq0 is a non-wakeup interrupt bank; change EINTW -> EINTN
> accordingly.
> > >
> > > Exynos8890
> > > - Per the SoC TRM, rename bank ect0 to gpb3 and mark it as
> > >   a non-external interrupt bank.
> > > - gpi1, gpi2: update bank type to match the SoC TRM.
> > >   exynos8895_bank_type_off (.fld_width = {4,1,2,3,2,2}) ->
> > >   exynos5433_bank_type_off (.fld_width = {4,1,2,4,2,2})
> > > - Per the SoC TRM, mark etc1 as a non-external interrupt bank.
> > > - apply lower case style for hex numbers.
> > >
> > > Exynos8895
> > > - gpa4 is a non-wakeup interrupt bank per the SoC TRM.
> > >   change EINTW -> EINTN. (The bank_type itself was correct and is kept
> > >   unchanged.)
> > > - apply lower case style for hex numbers.
> > >
> > > This aligns the pin-bank tables with the documented bitfield layouts
> > > and wakeup domains. No DT/ABI change.
> > >
> > > Signed-off-by: Youngmin Nam <youngmin.nam at samsung.com>
> > > Reviewed-by: Sam Protsenko <semen.protsenko at linaro.org>
> > > Reviewed-by: Ivaylo Ivanov <ivo.ivanov.ivanov1 at gmail.com>
> > > Tested-by: Sam Protsenko <semen.protsenko at linaro.org>
> > > ---
> >
> > This patch contains some worthwhile fixes for multiple Exynos SoCs. Do
> > you plan to re-send it? I think it would be good to get this merged
> > (even if there isn't broad agreement around renaming the pinctrl
> > macros to EXYNOS9_)
> >
> Can we relook into this series?
> AFA EXYNOS9_ macro is concern, Exynos990, Exynos9810 etc already support
> available upstream.
> Of course it does not justify why Exynos9, but we can consider all SoCs
> which has come after 2020 have this newer architecture.
> Or Just have SAMSUNG_ prefix for all such newer SoC.
> 
> A unified Macro help in adding new SoC support without much confusion(like
> I am trying with Exynos8855)
> 
> @Youngmin, will you have some time to re-spin these series?
> 

Sure. Let me re visit my patches and will try.


> > Thanks,
> >
> > Peter
>