[PATCH 1/3] dt-bindings: can: rockchip: add rk3588v2 CAN-FD compatible
Krzysztof Kozlowski
krzk at kernel.org
Thu Jul 2 00:43:16 PDT 2026
On Wed, Jul 01, 2026 at 03:01:26PM +0800, 1579567540 at qq.com wrote:
> From: luch00 <1579567540 at qq.com>
>
> The RK3588 CAN-FD controller uses the same DT properties as the
> existing Rockchip CAN-FD blocks, so extend the current schema with a
DT properties have nothing to do here. Are you saying it is fully
compatible? Then express it properly with fallback.
> SoC-specific rockchip,rk3588v2-canfd compatible instead of creating a
> new binding file.
>
> Keep RK3588v2 as its own compatible rather than an rk3568v2 fallback.
Do not explain what you did. Explain WHY.
> Driver support uses separate match data and the RX FIFO count field
Driver is irrelevant here.
> layout differs from rk3568v2, so a dedicated compatible is the safer
> description.
>
> Signed-off-by: luch00 <1579567540 at qq.com>
We do not take anonymous contributions.
> ---
> .../devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml
> index a077c0330..aa31ec78e 100644
> --- a/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> oneOf:
> - const: rockchip,rk3568v2-canfd
> + - const: rockchip,rk3588v2-canfd
So that's just enum with previous entry
And why is this different from rk3588?
> - items:
> - const: rockchip,rk3568v3-canfd
> - const: rockchip,rk3568v2-canfd
> --
> 2.34.1
>
More information about the linux-arm-kernel
mailing list