[PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices

[Chin-Ting Kuo]

Hi Mark,

Thanks for the review.

> -----Original Message-----
> From: Mark Brown <broonie at kernel.org>
> Sent: Friday, January 16, 2026 2:02 AM
> Subject: Re: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices
> 
> On Thu, Jan 15, 2026 at 11:04:54PM +0800, Chin-Ting Kuo wrote:
> 
> > +static int aspeed_spi_user_transfer(struct spi_controller *ctlr,
> > +				    struct spi_message *msg)
> > +{
> 
> I'm not seeing anything here that won't work with transfer_one() rather than
> transfer_one_message(), that would reduce open coding so if you can do it it's
> preferable.
> 

Okay, I will change the implementation to transfer_one() in the next patch version.

> > +	ctrl_val = chip->ctl_val[ASPEED_SPI_BASE];
> > +	ctrl_val &= ~CTRL_IO_MODE_MASK & data->hclk_mask;
> > +	ctrl_val |= clk_div;
> > +	chip->ctl_val[ASPEED_SPI_BASE] = ctrl_val;
> 
> This should fit with the prepare_message() callback.

Okay, prepare_message() and unprepare_message() callback functions will be created in the next patch version.


Chin-Ting