[PATCH] spi: xilinx: use device property accessors.
Abdurrahman Hussain
abdurrahman at nexthop.ai
Fri Jan 16 12:17:18 PST 2026
> On Jan 16, 2026, at 12:11 PM, Andrew Lunn <andrew at lunn.ch> wrote:
>
> On Fri, Jan 16, 2026 at 12:00:35PM -0800, Abdurrahman Hussain wrote:
>>
>>
>>> On Jan 16, 2026, at 7:23 AM, Andrew Lunn <andrew at lunn.ch> wrote:
>>>
>>> On Thu, Jan 15, 2026 at 12:33:28AM +0000, Abdurrahman Hussain wrote:
>>>> This makes the driver work on non-OF platforms.
>>>> Also, make irq optional, since the driver can already work in
>>>> polling mode.
>>>
>>> Are you saying ACPI cannot describe interrupts?
>>>
>>> Andrew
>>
>
>> It can. We have enabled the interrupts through ACPI on Xilinx I2C
>> block and it works great. For the SPI block we currently have an
>> issue with our FPGA. Luckily the driver works just fine in the
>> polling mode. By just making the interrupts optional makes the same
>> driver usable on a wider range of hardware platforms, with or
>> without the interrupts.
>
> It would be good to split this change into two patches, one making the
> interrupt optional, and one swapping to device_foo calls. They are
> logically different changes. And the commit message can then explain
> you are doing this so the driver works with hardware with broken
> interrupts.
>
> Actually, you need three patches, you need to change the DT binding,
> spi-xilinx.yaml, since currently interrupts are required, not
> optional.
>
> Andrew
Sounds good! I will split this change into three patches and re-submit.
Thanks for your review, Andrew!
Regards,
Abdurrahman
More information about the linux-arm-kernel
mailing list