[PATCH v2 04/13] dmaengine: mxs-dma: Use dev_err_probe() to simplify code
Frank Li
Frank.Li at nxp.com
Thu Jan 15 08:06:43 PST 2026
Use dev_err_probe() simplify code. No functional change.
Signed-off-by: Frank Li <Frank.Li at nxp.com>
---
drivers/dma/mxs-dma.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index dbc8747de591cc83e39ef873633418f41b5ea982..c1d4c6690df1af476aeafe77ff7f78bff1e413f1 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -753,10 +753,8 @@ static int mxs_dma_probe(struct platform_device *pdev)
return -ENOMEM;
ret = of_property_read_u32(np, "dma-channels", &mxs_dma->nr_channels);
- if (ret) {
- dev_err(dev, "failed to read dma-channels\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to read dma-channels\n");
dma_type = (struct mxs_dma_type *)of_device_get_match_data(dev);
mxs_dma->type = dma_type->type;
@@ -816,17 +814,13 @@ static int mxs_dma_probe(struct platform_device *pdev)
mxs_dma->dma_device.device_issue_pending = mxs_dma_enable_chan;
ret = dmaenginem_async_device_register(&mxs_dma->dma_device);
- if (ret) {
- dev_err(dev, "unable to register\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "unable to register\n");
ret = of_dma_controller_register(np, mxs_dma_xlate, mxs_dma);
- if (ret) {
- dev_err(dev,
- "failed to register controller\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to register controller\n");
dev_info(mxs_dma->dma_device.dev, "initialized\n");
--
2.34.1
More information about the linux-arm-kernel
mailing list