[PATCH] i2c: exynos5: simplify probe with devm

Andi Shyti andi.shyti at kernel.org
Thu Jan 15 07:31:00 PST 2026


Hi Rosen,

On Wed, Dec 17, 2025 at 12:49:44PM -0800, Rosen Penev wrote:
> Cleans up probe a little bit and separates preparation from enablement.
> 
> Also use devm for i2c_add_adapter to get rid of the remove function.
> 
> Fix return code for failed clk_get_prepared. It returns PTR_ERR.

The patch is good, but this commit log is messy. Please send a
new version of the commit log where you describe or list things
you have changed using the imperative form (sentences like
"Cleans up probe a little bit" mean very little).

No need to resend, just reply to this email and I can update the
log before merging.

Thanks,
Andi

> Signed-off-by: Rosen Penev <rosenp at gmail.com>



More information about the linux-arm-kernel mailing list