[PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

[Bough Chen]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 2026年1月15日 17:39
> To: Bough Chen <haibo.chen at nxp.com>
> Cc: Han Xu <han.xu at nxp.com>; Mark Brown <broonie at kernel.org>; Rob
> Herring <robh at kernel.org>; Krzysztof Kozlowski <krzk+dt at kernel.org>; Conor
> Dooley <conor+dt at kernel.org>; Shawn Guo <shawnguo at kernel.org>; Sascha
> Hauer <s.hauer at pengutronix.de>; Pengutronix Kernel Team
> <kernel at pengutronix.de>; Fabio Estevam <festevam at gmail.com>;
> linux-spi at vger.kernel.org; imx at lists.linux.dev; devicetree at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
> 
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen at nxp.com>
> > ---
> >  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index
> >
> a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13
> a32
> > 65315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> >      oneOf:
> >        - enum:
> >            - nxp,imx94-xspi
> > +      - items:
> > +          - enum:
> > +              - nxp,imx952-xspi
> > +          - const: nxp,imx94-xspi
> 
> You never checked your DTS and broke all existing users. And existing tools
> would clearly tell you that if you tried.
> 
> Use tools instead of reviewers. Reviewers time is more important, so if you just
> disregard it I find it quite disrespectful.

Hi Krzysztof,

I did run dt binding check before I send out this patch.
I list the log in the following, no error report.
Can you help point out where I have to improve?

nxa12937 at shlinux89:~/linux-next$ make64 distclean
  CLEAN   Documentation/devicetree/bindings
  CLEAN   scripts/basic
  CLEAN   scripts/dtc
  CLEAN   scripts/kconfig
  CLEAN   include/config include/generated .config
nxa12937 at shlinux89:~/linux-next$ make64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/dtc
  CHKDT   ./Documentation/devicetree/bindings
  LINT    ./Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dts
  DTC [C] Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dtb

Regards
Haibo Chen
> 
> Best regards,
> Krzysztof