Re: [PATCH] arm64:?==?utf-8?q? dts: rockchip: Remove hdmi_sound on rk3399-pinebook-pro

[Dragan Simic]

Hello Jun,

On Monday, January 12, 2026 15:13 CET, Jun Yan <jerrysteve1101 at gmail.com> wrote:
> According to the Pinebook Pro specification, it lacks HDMI port,
> but hdmi_sound is wrongly enabled.
> 
> This fixes the following warning:
> 
> platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error

Thanks for this patch!  I'd suggest that the patch description is rewritten
a bit using the standard imperative mood, and without relying on the patch
subject or the patch itself for establishing the required context.

For example, it may all read like this:

  arm64: dts: rockchip: Do not enable hdmi_sound node on Pinebook Pro

  Remove the redundant enabling of the hdmi_sound node in the Pinebook Pro
  board dts file, because the HDMI output is unused on this device. [1][2]
  This also eliminates the following warning from the kernel log, which
  also gets emitted on some other devices with HDMI ports, caused by some
  other reasons that are still unclear:

    platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error

  [1] https://files.pine64.org/doc/PinebookPro/pinebookpro_v2.1_mainboard_schematic.pdf
  [2] https://files.pine64.org/doc/PinebookPro/pinebookpro_schematic_v21a_20220419.pdf

As described above, getting rid of the quoted kernel warning is actually
a nice side effect, so to speak.

> Fixes: 5a65505a69884 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
> Signed-off-by: Jun Yan <jerrysteve1101 at gmail.com>

The tags should also include "Cc: stable at vger.kernel.org", to have this fix
propagated into the stable kernels as well.

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> index eaaca08a7601..a6ac89567baf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> @@ -421,10 +421,6 @@ &gpu {
>  	status = "okay";
>  };
>  
> -&hdmi_sound {
> -	status = "okay";
> -};
> -
>  &i2c0 {
>  	clock-frequency = <400000>;
>  	i2c-scl-falling-time-ns = <4>;