[PATCH v3 1/3] dt-bindings: usb: Add binding for WCH CH334/CH335 hub controller

Krzysztof Kozlowski krzk at kernel.org
Mon Jan 12 23:41:13 PST 2026


On 13/01/2026 04:27, Chaoyi Chen wrote:
> Hi Krzysztof,
> 
> On 1/12/2026 10:28 PM, Krzysztof Kozlowski wrote:
>> On 12/01/2026 09:59, Chaoyi Chen wrote:
>>>>> +required:
>>>>> +  - compatible
>>>>> +  - reg
>>>>> +
>>>>> +additionalProperties: false
>>>>> +
>>>>> +examples:
>>>>> +  - |
>>>>> +    #include <dt-bindings/gpio/gpio.h>
>>>>> +    usb {
>>>>> +        dr_mode = "host";
>>
>> One more thing - drop above line.
>>
> 
> Will fix in next version.
> 
>>>>> +        #address-cells = <1>;
>>>>> +        #size-cells = <0>;
>>>>> +
>>>>> +        hub: hub at 1 {
>>>>> +            compatible = "usb1a86,8091";
>>>>> +            reg = <1>;
>>>>> +            reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>>>>
>>>> Are you sure?
>>>
>>> I guess what you're concerned about here is the polarity? 
>>> If that's the case, then there's no problem.
>>
>> Yes, I was wondering whether polarity is set correctly.
> 
> Yes, it is active-low, so during normal operation it should be set to high.

Then it is wrong.

> 


Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list