[PATCH v3 1/3] dt-bindings: usb: Add binding for WCH CH334/CH335 hub controller

Chaoyi Chen chaoyi.chen at rock-chips.com
Mon Jan 12 19:27:42 PST 2026


Hi Krzysztof,

On 1/12/2026 10:28 PM, Krzysztof Kozlowski wrote:
> On 12/01/2026 09:59, Chaoyi Chen wrote:
>>>> +required:
>>>> +  - compatible
>>>> +  - reg
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    #include <dt-bindings/gpio/gpio.h>
>>>> +    usb {
>>>> +        dr_mode = "host";
> 
> One more thing - drop above line.
> 

Will fix in next version.

>>>> +        #address-cells = <1>;
>>>> +        #size-cells = <0>;
>>>> +
>>>> +        hub: hub at 1 {
>>>> +            compatible = "usb1a86,8091";
>>>> +            reg = <1>;
>>>> +            reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>>>
>>> Are you sure?
>>
>> I guess what you're concerned about here is the polarity? 
>> If that's the case, then there's no problem.
> 
> Yes, I was wondering whether polarity is set correctly.

Yes, it is active-low, so during normal operation it should be set to high.

-- 
Best, 
Chaoyi



More information about the linux-arm-kernel mailing list