[PATCH 2/2] ARM: dts: aspeed: Add Asus IPMI card

[Anirudh Srinivasan]

Hi Krzysztof,

On Mon, Jan 12, 2026 at 5:48 AM Krzysztof Kozlowski <krzk at kernel.org> wrote:
>
> > +
> > +     leds {
> > +             compatible = "gpio-leds";
> > +
> > +             led-fault {
> > +                     gpios = <&gpio1 ASPEED_GPIO(C, 5) GPIO_ACTIVE_HIGH>;
> > +                     panic-indicator;
> > +                     default-state = "off";
>
> Missing color and function. Or at least label.

I will add this.

>
> > +             };
> > +
> > +             led-heartbeat {
> > +                     gpios = <&gpio0 ASPEED_GPIO(A, 7) GPIO_ACTIVE_LOW>;
> > +                     linux,default-trigger = "timer";
> > +             };
> > +
>
> Drop redundant blank lines.
>
> > +&mac2 {
> > +     status = "okay";
> > +
> > +     /* Bootloader sets up the MAC to insert delay */
> > +     phy-mode = "rgmii";
> > +     phy-handle = <&ethphy2>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_rgmii3_default>;
> > +};
> > +
> > +
>
> Like this as well. It's a sign of sloppy coding.

Will remove

>
> > +&fmc {
> > +     status = "okay";
> > +
> > +     flash at 0 {
> > +             status = "okay";
> > +             m25p,fast-read;
> > +             label = "bmc";
> > +             spi-max-frequency = <50000000>;
> > +#include "openbmc-flash-layout-64.dtsi"
> > +     };
> > +};
>
> Best regards,
> Krzysztof
>

-- 
Regards
Anirudh Srinivasan