[PATCH 02/11] arm64: dts: mediatek: mt8183: Fix dtb warnings in display graph

Chen-Yu Tsai wenst at chromium.org
Sun Jan 11 23:19:41 PST 2026


On Fri, Jan 9, 2026 at 7:48 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno at collabora.com> wrote:

No commit message?

> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 119 +++++------------------
>  1 file changed, 23 insertions(+), 96 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index db86e2bd0c7b..676f8ecd89e2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi

[...]

> @@ -1904,9 +1880,9 @@ ports {
>                                 #size-cells = <0>;
>
>                                 port at 0 {
> -                                       reg = <0>;
>                                         #address-cells = <1>;
>                                         #size-cells = <0>;
> +                                       reg = <0>;

reg should be first or second (when the first property is "compatible")
property under a node.

Ref: "Order of Properties in Device Node" in
     Documentation/devicetree/bindings/dts-coding-style.rst

>
>                                         rdma1_in: endpoint at 1 {
>                                                 reg = <1>;
> @@ -1915,9 +1891,9 @@ rdma1_in: endpoint at 1 {
>                                 };
>
>                                 port at 1 {
> -                                       reg = <1>;
>                                         #address-cells = <1>;
>                                         #size-cells = <0>;
> +                                       reg = <1>;

Same here.

>
>                                         rdma1_out: endpoint at 1 {
>                                                 reg = <1>;

[...]

> @@ -2165,9 +2092,9 @@ ports {
>                                 #size-cells = <0>;
>
>                                 port at 0 {
> -                                       reg = <0>;
>                                         #address-cells = <1>;
>                                         #size-cells = <0>;
> +                                       reg = <0>;
>
>                                         dpi_in: endpoint at 1 {
>                                                 reg = <1>;
> @@ -2176,11 +2103,11 @@ dpi_in: endpoint at 1 {
>                                 };
>
>                                 port at 1 {
> -                                       reg = <1>;
>                                         #address-cells = <1>;
>                                         #size-cells = <0>;
> +                                       reg = <1>;
>
> -                                       dpi_out: endpoint at 1 {
> +                                       dpi_out: endpoint at 1  {
>                                                 reg = <1>;
>                                         };
>                                 };

Same for these two blocks.

So all the deletions are correct, but the simple reordering is wrong and
not needed.

Once fixed,

Reviewed-by: Chen-Yu Tsai <wenst at chromium.org>

ChenYu



More information about the linux-arm-kernel mailing list