[PATCH 2/2] ARM: dts: aspeed: Add Asus IPMI card
Anirudh Srinivasan
anirudhsriniv at gmail.com
Sun Jan 11 18:35:47 PST 2026
Hi Andrew,
On Sun, Jan 11, 2026 at 7:47 PM Andrew Jeffery
<andrew at codeconstruct.com.au> wrote:
>
> > +/ {
> > + model = "ASUS IPMI Card BMC";
>
> I'd drop the "BMC" from the model description as well (wrt the
> discussion on patch 1/2).
Yes, I realized sticking to its official name everywhere might just
make better sense.
I'll make this name "ASUS IPMI Expansion Card", change the compatible
to "asus,ipmi-expansion-card" and the dtb name to
"aspeed-bmc-asus-ipmi-expansion-card.dtb".
>
> This looks good in general.
>
> For the purpose of review I've started requesting that phandle
> references be ordered alphabetically, because it's tedious to confirm
> they're ordered by unit address, and it's nice to have consistency
> across the files. Can you please fix that along with Andrew Lunn's
> concern about the phy-mode?
Will fix this up and resend another series. Thanks for your quick response.
--
Regards
Anirudh Srinivasan
More information about the linux-arm-kernel
mailing list