[PATCH v7 3/4] clk: samsung: Implement automatic clock gating mode for CMUs

[Peter Griffin]

Hi André & Marek,

On Thu, 8 Jan 2026 at 10:55, André Draszik <andre.draszik at linaro.org> wrote:
>
> Hi Marek,
>
> On Thu, 2026-01-08 at 00:59 +0100, Marek Szyprowski wrote:
> > > @@ -334,10 +456,20 @@ void samsung_clk_extended_sleep_init(void __iomem *reg_base,
> > >     * samsung_cmu_register_clocks() - Register all clocks provided in CMU object
> > >     * @ctx: Clock provider object
> > >     * @cmu: CMU object with clocks to register
> > > + * @np:  CMU device tree node
> > >     */
> > >    void __init samsung_cmu_register_clocks(struct samsung_clk_provider *ctx,
> > > -                                   const struct samsung_cmu_info *cmu)
> > > +                                   const struct samsung_cmu_info *cmu,
> > > +                                   struct device_node *np)
> > >    {
> > > +   if (samsung_is_auto_capable(np) && cmu->auto_clock_gate)
> > > +           ctx->auto_clock_gate = cmu->auto_clock_gate;
> >
> > Do we need to issue "incorrect res size for automatic clocks" warning
> > for every legacy Exynos based board? The check above should be in
> > reverse order:
> >
> > if (cmu->auto_clock_gates && amsung_is_auto_capable(np))
> >       ctx->auto_clock_gate = cmu->auto_clock_gate;
>
> Good suggestion. I have one or two cleanups anyway, I'll add that as well.
>
> Thanks for spotting this!

Ok great thanks André and Marek!

Peter