[PATCH v19 01/10] power: reset: reboot-mode: Remove devres based allocations
Shivendra Pratap
shivendra.pratap at oss.qualcomm.com
Mon Jan 5 22:31:00 PST 2026
On 1/6/2026 3:01 AM, Dmitry Baryshkov wrote:
> On Mon, Jan 05, 2026 at 11:46:40PM +0530, Shivendra Pratap wrote:
>>
>>
>> On 1/2/2026 3:35 PM, Bartosz Golaszewski wrote:
>>> On Sun, Dec 28, 2025 at 6:20 PM Shivendra Pratap
>>> <shivendra.pratap at oss.qualcomm.com> wrote:
>>
>> [snip]
>>
>>>
>>>> + pr_err("reboot mode %s without magic number\n", prop->name);
>>>
>>> If this is an error, shouldn't we bail out?
>>>
>>>> + continue;
>>
>> This is not an error as per original design of reboot-mode framework.
>> The code as of now says, if the reboot-mode node has an entry without
>> proper magic value, ignore it, and, process the next.
>
> Then why are you using error level for the message printout?
I have changed from dev_err to pr_err. Can make it pr_info. Will
that change need a mention in commit text?
thanks,
Shivendra
More information about the linux-arm-kernel
mailing list