[PATCH v3 3/4] KVM: selftests: arm64: Make set_id_regs bitfield validatity checks non-fatal
Ben Horgan
ben.horgan at arm.com
Fri Jan 2 06:45:04 PST 2026
Hi Mark,
On 12/19/25 19:28, Mark Brown wrote:
> Currently when set_id_regs encounters a problem checking validation of
> writes to feature registers it uses an immediately fatal assert to report
> the problem. This is not idiomatic for kselftest, and it is also not great
> for usability. The affected bitfield is not clearly reported and further
> tests do not have their results reported.
>
> Switch to using standard kselftest result reporting for the two asserts
> we do, these are non-fatal asserts so allow the program to continue and the
> test names include the affected field.
>
> Signed-off-by: Mark Brown <broonie at kernel.org>
> ---
> tools/testing/selftests/kvm/arm64/set_id_regs.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
This one also looks good to me. I'm not aware of why the asserts have
been favoured previously though.
Reviewed-by: Ben Horgan <ben.horgan at arm.com>
Thanks,
Ben
More information about the linux-arm-kernel
mailing list