[PATCH] scsi: ufs: exynos: Propagate PHY power-on errors
Pengpeng Hou
pengpeng at iscas.ac.cn
Fri Aug 28 02:22:13 PDT 2026
The Exynos UFS variant resume hook powers on the PHY when the link is
inactive but ignores the result and continues with SMU and FMP
restoration.
Return the PHY error before touching the controller-specific state.
The issue was identified via static analysis and manually reviewed.
Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs")
Assisted-by: LLM
Signed-off-by: Pengpeng Hou <pengpeng at iscas.ac.cn>
---
drivers/ufs/host/ufs-exynos.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index b2f65c465525..35fc0673fd03 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -1829,9 +1829,13 @@ static int exynos_ufs_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op,
static int exynos_ufs_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
{
struct exynos_ufs *ufs = ufshcd_get_variant(hba);
+ int ret;
- if (!ufshcd_is_link_active(hba))
- phy_power_on(ufs->phy);
+ if (!ufshcd_is_link_active(hba)) {
+ ret = phy_power_on(ufs->phy);
+ if (ret)
+ return ret;
+ }
exynos_ufs_config_smu(ufs);
exynos_ufs_fmp_resume(hba);
--
2.43.0
More information about the linux-arm-kernel
mailing list