[PATCH v2 3/4] ASoC: mediatek: mt8183: Use dev_err_probe() for error handling
Cezary Rojewski
cezary.rojewski at intel.com
Wed Aug 26 11:32:22 PDT 2026
On 8/21/2026 2:29 PM, phucduc.bui at gmail.com wrote:
> From: bui duc phuc <phucduc.bui at gmail.com>
>
> Replace dev_err() with dev_err_probe() to prevent log spam when probe
> returns -EPROBE_DEFER.
>
> Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
> ---
> sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c
> index 0790d8123179..46cab62220d9 100644
> --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c
> +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c
> @@ -101,12 +101,9 @@ int mt8183_init_clock(struct mtk_base_afe *afe)
>
> for (i = 0; i < CLK_NUM; i++) {
> afe_priv->clk[i] = devm_clk_get(afe->dev, aud_clks[i]);
> - if (IS_ERR(afe_priv->clk[i])) {
> - dev_err(afe->dev, "%s(), devm_clk_get %s fail, ret %ld\n",
> - __func__, aud_clks[i],
> - PTR_ERR(afe_priv->clk[i]));
> - return PTR_ERR(afe_priv->clk[i]);
> - }
> + if (IS_ERR(afe_priv->clk[i]))
> + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]),
> + "failed to get clock %s\n", aud_clks[i]);
> }
>
> return 0;
Reviewed-by: Cezary Rojewski <cezary.rojewski at intel.com>
More information about the linux-arm-kernel
mailing list