[PATCH v9 06/12] iommu/arm-smmu-v3: Handle gerror during suspend
Pranjal Shrivastava
praan at google.com
Tue Aug 25 11:06:13 PDT 2026
On Tue, Aug 25, 2026 at 01:36:11PM -0300, Jason Gunthorpe wrote:
> > The GERROR register's state might be lost when the SMMU is powered down
> > during runtime suspend. Handle any pending errors before suspending.
> >
> > Refactor the gerror handling logic into a helper function and invoke it
> > from the runtime suspend callback after disabling the SMMU. This ensures
> > that any late-breaking gerrors are logged and ack'ed before the hardware
> > state is lost.
>
> The commit message isn't clear, this is just a refactoring patch it
> does not "Handle gerror during suspend"
>
> But the refactoring is fine
>
> Reviewed-by: Jason Gunthorpe <jgg at nvidia.com>
>
> Though sashiko seems right about the pre-existing bug.
>
Yes, we recently fixed the pre-existing bug with this:
https://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git/commit/?id=eced8058c82a
Thanks
Praan
More information about the linux-arm-kernel
mailing list