> I think keeping the function scope is clearer here :) I got an other impression because a pci_dev_put(pdev) call was applied before a devm_kasprintf() call. https://elixir.bootlin.com/linux/v7.2/source/drivers/perf/dwc_pcie_pmu.c#L695-L717 Regards, Markus