[PATCH v2] firmware: arm_scmi: pm: use DEFINE_SIMPLE_DEV_PM_OPS for pm struct

Uwe Kleine-König u.kleine-koenig at baylibre.com
Wed Aug 19 22:10:20 PDT 2026


On Thu, Aug 20, 2026 at 10:17:18AM +0800, Li Jun wrote:
> use DEFINE_SIMPLE_DEV_PM_OPS for scmi_dev_pm_ops,and add the value of
> .freeze .thaw .poweroff .restore.if these address are null, may cause
> error in s4.
> 
> Change:
> -Replace SIMPLE_DEV_PM_OPS() in v1 with DEFINE_SIMPLE_DEV_PM_OPS() for pm.
> 
> Signed-off-by: Li Jun <lijun01 at kylinos.cn>

The things I wrote at
https://lore.kernel.org/all/aoaFlNcXC8zfS0j5@monoceros/ mostly apply
here, too.

TL;DR: Wrong placement of inter-revision changelog, missing
pm_sleep_ptr(), and maybe most prominently the request for patience to
start with a single patch and learn from the feedback for later patches.

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20260820/f80eff44/attachment-0001.sig>


More information about the linux-arm-kernel mailing list