[PATCH v2 3/3] mmc: davinci: Handle optional IRQ return value correctly
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Wed Aug 12 22:34:04 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
host->sdio_irq is assigned from platform_get_irq_optional(), which
returns a positive IRQ number on success or a negative error code on
failure. Therefore, 0 is not a possible return value from this API.
Check for a positive IRQ number before requesting the SDIO IRQ instead
of treating zero as a valid IRQ.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
drivers/mmc/host/davinci_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 773577a10512..c503e5f5c886 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1303,7 +1303,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
if (ret)
goto mmc_add_host_fail;
- if (host->sdio_irq >= 0) {
+ if (host->sdio_irq > 0) {
ret = devm_request_irq(&pdev->dev, host->sdio_irq,
mmc_davinci_sdio_irq, 0,
mmc_hostname(mmc), host);
--
2.43.0
More information about the linux-arm-kernel
mailing list