[PATCH v13 01/11] dt-bindings: clock: Add Realtek RTD1625 Clock & Reset Controller

[Krzysztof Kozlowski]

On 12/08/2026 12:22, Yu-Chun Lin [林祐君] wrote:
>> On 12/08/2026 11:41, Yu-Chun Lin [林祐君] wrote:
>>> Hi Krzysztof,
>>>
>>>> On 12/08/2026 03:59, Yu-Chun Lin wrote:
>>>>> Add DT binding schema for Realtek RTD1625 clock and reset controller
>>>>>
>>>>> Reviewed-by: Krzysztof Kozlowski
>>>>> <krzysztof.kozlowski at oss.qualcomm.com>
>>>>
>>>> How my tag could appear here?
>>>>
>>>> Look:
>>>> https://lore.kernel.org/lkml/20260324025332.3416977-2-eleanor.lin@rea
>>>> ltek.c
>>>> om/
>>>>
>>>>> Co-developed-by: Cheng-Yu Lee <cylee12 at realtek.com>
>>>>> Signed-off-by: Cheng-Yu Lee <cylee12 at realtek.com>
>>>>> Signed-off-by: Yu-Chun Lin <eleanor.lin at realtek.com>
>>>>
>>>> Who added my tag? What is the actual flow of this patch?
>>>>
>>>
>>> You gave your Reviewed-by tag in v5. However, after that, Stephon
>>> provided additional feedback. In v6, I modified the patch based on
>>> Stephon's comments and made some other changes. Furthermore, I added
>>> the clock ID
>>> 144 in v11.
>>
>> So how my tag could appear before Cheng-Yu Lee signed off the patch?
>>
> 
> Ah, I read the rules stating that "the last Signed-off-by: must always be
> that of the developer submitting the patch".

This is correct interpretation (although some subsystems will interpret
above only in respect of other SoBs).

> 
> I mistakenly thought my Signed-off-by had to be the absolute last line of

This is correct.

> the entire commit message. Therefore, when I inserted your tag at the top
> of the tag block. 

This is odd result of earlier logic. If your SoB has to be the last,
then obvious choice is to put the Reviewed-by tag BEFORE your SoB.

And in any case you should use b4 since it would do the correct thing.
All patch submissions are supposed to use b4, so you don't make trivial
process mistakes.


Best regards,
Krzysztof