[PATCH 2/3] ASoC: mxs-saif: Drop redundant probe error messages
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Wed Aug 12 03:14:17 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
The functions called here don't log the error themselves, but the
error is already reported deeper in the call chain, so the dev_err()
calls are redundant and can be removed.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/mxs/mxs-saif.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index b877c978a04c..a77cd516a1bf 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -841,10 +841,8 @@ static int mxs_saif_probe(struct platform_device *pdev)
saif->dev = &pdev->dev;
ret = devm_request_irq(&pdev->dev, irq, mxs_saif_irq, 0,
dev_name(&pdev->dev), saif);
- if (ret) {
- dev_err(&pdev->dev, "failed to request irq\n");
+ if (ret)
return ret;
- }
platform_set_drvdata(pdev, saif);
@@ -857,16 +855,12 @@ static int mxs_saif_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_component(&pdev->dev, &mxs_saif_component,
&mxs_saif_dai, 1);
- if (ret) {
- dev_err(&pdev->dev, "register DAI failed\n");
+ if (ret)
return ret;
- }
ret = mxs_pcm_platform_register(&pdev->dev);
- if (ret) {
- dev_err(&pdev->dev, "register PCM failed: %d\n", ret);
+ if (ret)
return ret;
- }
return 0;
}
--
2.43.0
More information about the linux-arm-kernel
mailing list