[PATCH 1/7] pmdomain: arm: Fix -EINVAL from scmi_pd_set_perf_state() on state 0
Mukesh Savaliya
mukesh.savaliya at oss.qualcomm.com
Wed Aug 12 00:24:41 PDT 2026
On 8/5/2026 1:27 AM, Praveen Talari wrote:
[...]
> ---
> drivers/pmdomain/arm/scmi_perf_domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/arm/scmi_perf_domain.c b/drivers/pmdomain/arm/scmi_perf_domain.c
> index 3693423459c9..e390f902a444 100644
> --- a/drivers/pmdomain/arm/scmi_perf_domain.c
> +++ b/drivers/pmdomain/arm/scmi_perf_domain.c
> @@ -33,7 +33,7 @@ scmi_pd_set_perf_state(struct generic_pm_domain *genpd, unsigned int state)
> return 0;
>
> if (!state)
> - return -EINVAL;
> + return 0;
Won't this cause an issue to other drivers ? how are they going to take
action based on changed return value ?
Remove Acked-by due to this till i give back.
>
> ret = pd->perf_ops->level_set(pd->ph, pd->domain_id, state, false);
> if (ret)
>
More information about the linux-arm-kernel
mailing list