[PATCH v9 11/13] coresight: etm4x: remove s_ex_level from config

Yeoreum Yun yeoreum.yun at arm.com
Tue Aug 11 10:47:01 PDT 2026


On Tue, Aug 11, 2026 at 06:25:17PM +0100, Leo Yan wrote:
> On Sat, Jul 25, 2026 at 12:36:43PM +0100, Yeoreum Yun wrote:
> 
> [...]
> 
> > -static u64 etm4_get_access_type(struct etmv4_config *config)
> > +static u64 etm4_get_access_type(struct etmv4_config *config,
> > +				const struct etmv4_caps *caps)
> >  {
> 
> Is it possible to retrieve drvdata from config? Something like:
> 
>   drvdata = etm4_get_drvdata_from_config(config);
> 
> If this is feasible, we wouldn't need to modify so many functions to
> add the *caps argument.

It's feasible, however, I feel it doesn’t seem semantically appropriate.
Since, the etmv4_config is a configuration and TBH, it could be not
embedded in to etmv4_drvdata.

Though the usages where the chnaged fucntion, the config're all embeded.
However, If we introduce the etm4_get_drvdata_from_config(),
We need to check the drvdata pointer is valid since it passes the config
not embeded and this would be more strange.

So, I think it seems better to the caps arguments.

-- 
Sincerely,
Yeoreum Yun



More information about the linux-arm-kernel mailing list