[PATCH v9 10/13] coresight: etm4x: exclude ss_status from drvdata->config
Yeoreum Yun
yeoreum.yun at arm.com
Tue Aug 11 10:08:35 PDT 2026
On Tue, Aug 11, 2026 at 06:02:42PM +0100, Leo Yan wrote:
> On Sat, Jul 25, 2026 at 12:36:42PM +0100, Yeoreum Yun wrote:
> > The purpose of TRCSSCSRn register is to show status of
> > the corresponding Single-shot Comparator Control and input supports.
>
> I vaguely remember that we discussed the issue with always clearing
> drvdata::ss_status in hw_enable(), which might result in single-shot
> does not work properly in a perf session.
>
> This issue is not introduced by this patch, and I think we agreed to
> address it later. Could you document it in the commit log so that we
> can understand and track the issue later.
Okay. I'll add this in commit message.
>
> > That means writable field's purpose for reset or restore from idle status
> > not for configuration.
> >
> > Therefore, exclude ss_status from drvdata->config and move it to drvdata.
> >
> > Signed-off-by: Yeoreum Yun <yeoreum.yun at arm.com>
>
> With above amending:
>
> Reviewed-by: Leo Yan <leo.yan at arm.com>
Thanks!
--
Sincerely,
Yeoreum Yun
More information about the linux-arm-kernel
mailing list