[PATCH 4/4] watchdog: aspeed: Propagate errors from optional IRQ lookup

Bui Duc Phuc phucduc.bui at gmail.com
Sun Aug 9 19:38:17 PDT 2026


Hi Guenter,

Thank you for your review.

> > +             if (irq < 0 && irq != -ENXIO)
> > +                     return irq;
> >               if (irq > 0) {
>
> This if () is no longer needed.
>

If we remove the if (irq > 0) check, irq can be -ENXIO and would be
passed to devm_request_irq().
I see that the irq argument of devm_request_irq() is an unsigned int.
Would it be safe to pass -ENXIO to it in this case?

Best regards,
Phuc



More information about the linux-arm-kernel mailing list