[PATCH 1/2] spi: mtk-nor: Propagate errors from optional IRQ lookup
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Fri Aug 7 03:29:30 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure. For an optional IRQ, -ENXIO indicates
that no IRQ is available, while other errors should be propagated.
Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing
probe without the IRQ.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
drivers/spi/spi-mtk-nor.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c
index 74f34537b02c..6b9a5d728549 100644
--- a/drivers/spi/spi-mtk-nor.c
+++ b/drivers/spi/spi-mtk-nor.c
@@ -895,6 +895,10 @@ static int mtk_nor_probe(struct platform_device *pdev)
irq = platform_get_irq_optional(pdev, 0);
if (irq < 0) {
+ if (irq != -ENXIO) {
+ ret = irq;
+ goto err_disable_clk;
+ }
dev_warn(sp->dev, "IRQ not available.");
} else {
ret = devm_request_irq(sp->dev, irq, mtk_nor_irq_handler, 0,
@@ -928,6 +932,7 @@ static int mtk_nor_probe(struct platform_device *pdev)
pm_runtime_set_suspended(&pdev->dev);
pm_runtime_dont_use_autosuspend(&pdev->dev);
+err_disable_clk:
mtk_nor_disable_clk(sp);
return ret;
--
2.43.0
More information about the linux-arm-kernel
mailing list