[PATCH 03/14] ASoC: rockchip: rockchip_i2s: Use dev_err_probe() for error handling
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Wed Aug 5 22:21:25 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
Replace dev_err() with dev_err_probe() to prevent log spam when probe
returns -EPROBE_DEFER.
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/rockchip/rockchip_i2s.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index 64c90316fa02..3e8d07b3fc1e 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -767,16 +767,14 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
/* try to prepare related clocks */
i2s->hclk = devm_clk_get_enabled(&pdev->dev, "i2s_hclk");
- if (IS_ERR(i2s->hclk)) {
- dev_err(&pdev->dev, "Can't retrieve i2s bus clock\n");
- return PTR_ERR(i2s->hclk);
- }
+ if (IS_ERR(i2s->hclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2s->hclk),
+ "Can't retrieve i2s bus clock\n");
i2s->mclk = devm_clk_get(&pdev->dev, "i2s_clk");
- if (IS_ERR(i2s->mclk)) {
- dev_err(&pdev->dev, "Can't retrieve i2s master clock\n");
- return PTR_ERR(i2s->mclk);
- }
+ if (IS_ERR(i2s->mclk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(i2s->mclk),
+ "Can't retrieve i2s master clock\n");
regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(regs))
--
2.43.0
More information about the linux-arm-kernel
mailing list