[PATCH v10 3/6] mfd: max77759: add register bitmasks and modify irq configs for charger

[Krzysztof Kozlowski]

On 29/04/2026 02:29, Amit Sunil Dhamne wrote:
> Hi Lee,
> 
> 
> Thanks for your review.
> 
> 
> On 4/24/26 1:26 AM, Lee Jones wrote:
>> On Tue, 31 Mar 2026, Amit Sunil Dhamne via B4 Relay wrote:
>>
>>> From: Amit Sunil Dhamne <amitsd at google.com>
>>>
>>> Add register bitmasks for charger function.
>>> In addition split the charger IRQs further such that each bit represents
>>> an IRQ downstream of charger regmap irq chip. In addition populate the
>>> ack_base to offload irq ack to the regmap irq chip framework.
>> Please reword this commit messages.
>>
>> Using 'In addition' twice in such close proximity reads a little awkwardly.
> 
> Thanks for pointing it out. Unfortunately, this commit is already part
> of the linux and linux-next so I am not sure if I could fix the commit
> message retrospectively.

I don't understand why you decided to put this with USB patchset. We do
ask not to mix subsystems all the time. You made it unnecessarily
combination of at least three subsystems.

Do not do that.

Best regards,
Krzysztof