Since you got comments anyway... > } > > - irq_set_irq_type(gpio_to_irq(p54spi_gpio_irq), IRQ_TYPE_EDGE_RISING); > > INIT_WORK(&priv->work, p54spi_work); This leaves two adjacent blank lines. johannes