[PATCH 2/3] gpio: axiado: add SGPIO controller support

[Linus Walleij]

Hi Petar,

thanks for your patch!

On Tue, Apr 14, 2026 at 3:48 PM Petar Stepanovic <pstepanovic at axiado.com> wrote:

> Add support for the Axiado SGPIO controller.
>
> The controller provides a serialized interface for GPIOs with
> configurable direction and interrupt support.
>
> The driver registers the controller as a gpio_chip and uses
> regmap for register access.
>
> Signed-off-by: Petar Stepanovic <pstepanovic at axiado.com>

(...)

> +static void ax3000_sgpio_set(struct gpio_chip *chip, unsigned int offset,
> +                            int value)
> +{
> +       struct ax3000_sgpio *sgpio = gpiochip_get_data(chip);
> +       unsigned long flags;
> +       u32 bank = (offset / 2) / 32;
> +       u32 position = (offset / 2) % 32;

This systematic calculation of offsets from bank and position and the
whole bank concept makes me feel that perhaps the bindings are
better off reflecting the bank structure either by defining several banks
using 2 cells or by using a 3-cell binding?

For 3-cell see:
commit bd3ce71078bde4ecbfc60d49c96d1c55de0635cc
"gpiolib: of: Handle threecell GPIO chips"
for some details on how this can help.

Either of these approaches will further probably help you to
use GPIO_GENERIC (gpio-mmio) helper functions with this hardware,

Yours,
Linus Walleij