[PATCH v5 2/4] thermal: qoriq: add i.MX93 tmu support

Jacky Bai ping.bai at nxp.com
Tue Apr 21 02:59:10 PDT 2026


> Subject: Re: [PATCH v5 2/4] thermal: qoriq: add i.MX93 tmu support
> 

[...]

> >  static struct qoriq_tmu_data *qoriq_sensor_to_data(struct
> > qoriq_sensor *s) @@ -225,6 +232,8 @@ static int
> > qoriq_tmu_calibration(struct device *dev,
> >
> >  static void qoriq_tmu_init_device(struct qoriq_tmu_data *data)  {
> > +	u32 teumr0_val;
> 
> No need for this here you can just use directly: data->drvdata->teumr0
> 

Thx, will resolve it in next version.

BR

> > +
> >  	/* Disable interrupt, using polling instead */
> >  	regmap_write(data->regmap, REGS_TIER, TIER_DISABLE);
> >
> > @@ -234,7 +243,8 @@ static void qoriq_tmu_init_device(struct
> qoriq_tmu_data *data)
> >  		regmap_write(data->regmap, REGS_TMTMIR, TMTMIR_DEFAULT);
> >  	} else {
> >  		regmap_write(data->regmap, REGS_V2_TMTMIR,
> TMTMIR_DEFAULT);
> > -		regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V2);
> > +		teumr0_val = data->drvdata->teumr0;
> > +		regmap_write(data->regmap, REGS_V2_TEUMR(0), teumr0_val);
> >  	}
> 



More information about the linux-arm-kernel mailing list