[PATCH v4 2/4] pwm: sun50i: Add H616 PWM support
Richard GENOUD
richard.genoud at bootlin.com
Thu Apr 16 00:57:37 PDT 2026
Le 13/04/2026 à 14:39, bigunclemax at gmail.com a écrit :
> Hi Richard,
>
>> +
>> +/* PWM Capture Fall Lock Register */
>> +#define H616_PWM_CFLR(x) (0x74 + (x) * 0x20)
>> +
>> +#define H616_PWM_PAIR_IDX(chan) ((chan) >> 2)
>> +
>
> It looks like there's a typo or a mistake in the PAIR_IDX calculation.
> It should be like ((chan) >> 1).
> For example, for the 5th channel the result will be 1, but it should be 2.
Good catch!
I mainly tested with PWM1 as it's the only one easily accessible with a
scope.
I'll change that in the next iteration.
Thanks!
>
> Best regards
> Maksim
>
More information about the linux-arm-kernel
mailing list