[PATCH 02/10] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint()
Dmitry Baryshkov
dmitry.baryshkov at oss.qualcomm.com
Mon Apr 13 11:10:52 PDT 2026
On Mon, Apr 13, 2026 at 08:57:42PM +0300, Dmitry Baryshkov wrote:
> On Mon, Apr 13, 2026 at 03:58:34PM +0200, Luca Ceresoli wrote:
> > This driver calls drm_of_find_panel_or_bridge() with a NULL pointer in the
> > @panel parameter, thus using a reduced feature set of that function.
> > Replace this call with the simpler of_drm_get_bridge_by_endpoint().
> >
> > Since of_drm_get_bridge_by_endpoint() increases the refcount of the
> > returned bridge, ensure it is put on removal.
> >
> > Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
> > ---
> > drivers/gpu/drm/msm/hdmi/hdmi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> Acked-by: Dmitry Baryshkov <dmitry.baryshkov at oss.qualcomm.com>
>
> How common is the probe / remove path? Would it make sense to have a
> devm_ version of the function?
And probably the best way would be to change the driver to allocate the
bridge early and follow the rest of the bridge drivers. I will check it
out and possibly send a patch.
--
With best wishes
Dmitry
More information about the linux-arm-kernel
mailing list