[PATCH net-next 6/7] net: pch_gbe: convert to use ndo_hwtstamp callbacks
Jakub Kicinski
kuba at kernel.org
Fri Oct 31 11:38:40 PDT 2025
On Fri, 31 Oct 2025 18:35:25 +0100 Kory Maincent wrote:
> > case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
> > - adapter->hwts_rx_en = 0;
> > + adapter->hwts_rx_en = cfg->rx_filter;
>
> It seems there is a functional change here.
>
> > pch_ch_control_write(pdev, SLAVE_MODE | CAP_MODE0);
Good catch. Looks like SLAVE | MODE0 translates to 0 | 0
so presumably the device doesn't actually support timestamping
of V1 L4 SYNC messages? Unclear what to do about this.
Maybe let's leave it be? keep the hwts_rx_en = 0; ?
Not strictly correct but at least we won't break anything.
More information about the linux-arm-kernel
mailing list