[PATCH 2/4] remoteproc: imx_rproc: Add runtime ops copy to support dynamic behavior

[Peng Fan]

Hi Daniel,

> Subject: Re: [PATCH 2/4] remoteproc: imx_rproc: Add runtime ops
> copy to support dynamic behavior
> 
> Hi Peng,
> 
> One comment.
> 
> 
> > @@ -116,6 +116,7 @@ struct imx_rproc {
> >         u32                             entry;          /* cpu start address */
> >         u32                             core_index;
> >         struct dev_pm_domain_list       *pd_list;
> > +       struct imx_rproc_plat_ops       ops;
> >  };
> 
> Here do you plan to change a member of the ops table at runtime?
> Like e.g replace just the start ops? Or the entire table.
> 
> Because it would be better to add something like this:

Need to change start/stop/prepare, no need change detect_mode.
But it should be ok to change to const pointer per your suggestion.

I will follow this in next version.

Thanks,
Peng.

> 
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -116,7 +116,7 @@ struct imx_rproc {
>         u32                             entry;          /* cpu start address */
>         u32                             core_index;
>         struct dev_pm_domain_list       *pd_list;
> -       struct imx_rproc_plat_ops       ops;
> +       const struct imx_rproc_plat_ops       *ops;
>  };