[PATCH V3] net: ethernet: ti: netcp: Standardize knav_dma_open_channel to return NULL on error

Jacob Keller jacob.e.keller at intel.com
Wed Oct 29 13:07:54 PDT 2025



On 10/29/2025 6:23 AM, Nishanth Menon wrote:
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index a25ebe6cd503..e69f0946de29 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -402,7 +402,7 @@ static int of_channel_match_helper(struct device_node *np, const char *name,
>   * @name:	slave channel name
>   * @config:	dma configuration parameters
>   *
> - * Returns pointer to appropriate DMA channel on success or error.
> + * Returns pointer to appropriate DMA channel on success or NULL on error.
>   */

Minor nit: you could make this a proper kdoc returns by using "Return:"
or "Returns:" here to introduce this as a section instead of just a comment.

That would fix a kdoc warning too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20251029/6029a960/attachment.sig>


More information about the linux-arm-kernel mailing list