[PATCH v5 01/10] net: stmmac: dwmac-socfpga: don't set has_gmac

[G Thomas, Rohan]

Hi Steffen,

On 10/24/2025 6:00 PM, Steffen Trumtrar wrote:
> 
> Hi Maxime,
> 
> On 2025-10-24 at 14:11 +02, Maxime Chevallier 
> <maxime.chevallier at bootlin.com> wrote:
> 
>> Hi Steffen
>>
>> On 24/10/2025 13:49, Steffen Trumtrar wrote:
>> > Instead of setting the has_gmac or has_xgmac fields, let
>> > stmmac_probe_config_dt()) fill these fields according to the more
>> > generic compatibles.
>> > > Without setting the has_xgmac/has_gmac field correctly, even basic
>> > functions will fail, because the register offsets are different.
>> > > Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
>> > ---
>> >  drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 -
>> >  1 file changed, 1 deletion(-)
>> > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c 
>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> > index 354f01184e6cc..7ed125dcc73ea 100644
>> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> > @@ -497,7 +497,6 @@ static int socfpga_dwmac_probe(struct 
>> platform_device *pdev)
>> >      plat_dat->pcs_init = socfpga_dwmac_pcs_init;
>> >      plat_dat->pcs_exit = socfpga_dwmac_pcs_exit;
>> >      plat_dat->select_pcs = socfpga_dwmac_select_pcs;
>> > -    plat_dat->has_gmac = true;

I was preparing a patch-set to enable additional features in Agilex5.
Since Agilex5 HPS EMAC has different configurations from the previous
platforms adding a separate platform setup callback for Agilex5 and
other platforms. Here is the link to this patch-set:
https://lore.kernel.org/all/20251029-agilex5_ext-v1-0-1931132d77d6@altera.com/

Could you please confirm if this patch set aligns with your commit?

>>
>> Note that this field is now gone as per :
>>
>>   26ab9830beab ("net: stmmac: replace has_xxxx with core_type")
>>
>> You'll need to rebase the series :)
>>
> 
> I see, bad timing, but luckily an easy patch :)
> 
> 
> Best regards,
> Steffen
> 
Best Regards,
Rohan