[PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2
Diederik de Haas
diederik at cknow-tech.com
Sun Oct 26 11:44:34 PDT 2025
Hi,
On Sun Oct 26, 2025 at 6:36 PM CET, Dragan Simic wrote:
> On Sunday, October 26, 2025 18:25 CET, Diederik de Haas <diederik at cknow-tech.com> wrote:
>> Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
>> source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
>> VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.
>>
>> Signed-off-by: Diederik de Haas <diederik at cknow-tech.com>
>
> Thanks for this patch. As already discussed in private, this is
> correct and safe to do, because both supplies are designated as
> always-on, so please feel free to include:
>
> Reviewed-by: Dragan Simic <dsimic at manjaro.org>
Thanks :-)
> Though, I think this cleanup should also be propagated into the
> stable kernels. Right now this patch doesn't actually introduce
> any functional changes, but maybe in the future there will be
> some related driver or DT changes or improvements that may end up
> relying on DT correction such as this one.
Fair point. Dunno if b4 picks this up automatically ...
Fixes: 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64 PineTab2")
Cheers,
Diederik
>> ---
>> arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> index d0e38412d56a..08bf40de17ea 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
>> @@ -789,7 +789,7 @@ &pmu_io_domains {
>> vccio1-supply = <&vccio_acodec>;
>> vccio2-supply = <&vcc_1v8>;
>> vccio3-supply = <&vccio_sd>;
>> - vccio4-supply = <&vcc_1v8>;
>> + vccio4-supply = <&vcca1v8_pmu>;
>> vccio5-supply = <&vcc_1v8>;
>> vccio6-supply = <&vcc1v8_dvp>;
>> vccio7-supply = <&vcc_3v3>;
More information about the linux-arm-kernel
mailing list