[PATCH net-next] net: stmmac: mdio: fix smatch warning

Heiner Kallweit hkallweit1 at gmail.com
Sat Oct 25 11:33:37 PDT 2025


On 10/24/2025 9:26 PM, Heiner Kallweit wrote:
> max_addr is the max number of addresses, not the highest possible address,
> therefore check phydev->mdio.addr > max_addr isn't correct.
> To fix this change the semantics of max_addr, so that it represents
> the highest possible address. IMO this is also a little bit more intuitive
> wrt name max_addr.
> 
> Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
> Reported-by: Simon Horman <horms at kernel.org>
> Fixes: 4a107a0e8361 ("net: stmmac: mdio: use phy_find_first to simplify stmmac_mdio_register")
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
> ---

CI complains about the patch title, so I'll change it and send a v2.

--
pw-bot: cr



More information about the linux-arm-kernel mailing list