[PATCH v5 01/10] net: stmmac: dwmac-socfpga: don't set has_gmac
Maxime Chevallier
maxime.chevallier at bootlin.com
Fri Oct 24 05:11:45 PDT 2025
Hi Steffen
On 24/10/2025 13:49, Steffen Trumtrar wrote:
> Instead of setting the has_gmac or has_xgmac fields, let
> stmmac_probe_config_dt()) fill these fields according to the more
> generic compatibles.
>
> Without setting the has_xgmac/has_gmac field correctly, even basic
> functions will fail, because the register offsets are different.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> index 354f01184e6cc..7ed125dcc73ea 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> @@ -497,7 +497,6 @@ static int socfpga_dwmac_probe(struct platform_device *pdev)
> plat_dat->pcs_init = socfpga_dwmac_pcs_init;
> plat_dat->pcs_exit = socfpga_dwmac_pcs_exit;
> plat_dat->select_pcs = socfpga_dwmac_select_pcs;
> - plat_dat->has_gmac = true;
Note that this field is now gone as per :
26ab9830beab ("net: stmmac: replace has_xxxx with core_type")
You'll need to rebase the series :)
Maxime
>
> plat_dat->riwt_off = 1;
>
>
More information about the linux-arm-kernel
mailing list