[PATCH net-next 3/8] net: stmmac: consolidate version reading and validation
Andrew Lunn
andrew at lunn.ch
Thu Oct 23 11:48:01 PDT 2025
On Thu, Oct 23, 2025 at 10:37:34AM +0100, Russell King (Oracle) wrote:
> There is no need to read the version register twice, once in
> stmmac_get_id() and then again in stmmac_get_dev_id(). Consolidate
> this into stmmac_get_version() and pass each of these this value.
>
> As both functions unnecessarily issue the same warning for a zero
> register value, also move this into stmmac_get_version().
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew at lunn.ch>
Andrew
More information about the linux-arm-kernel
mailing list