[PATCH v2 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees

[Alexander Stein]

Hi Andrew,

Am Montag, 20. Oktober 2025, 20:34:16 CEST schrieb Andrew Lunn:
> > +&enetc_mdio_pf3 {
> > +	mdio0_rgmii_phy00: ethernet-phy at 0 {
> > +		compatible = "ethernet-phy-ieee802.3-c22";
> > +		reg = <0x00>;
> > +		reset-gpios = <&gpio_exp_1v8 1 GPIO_ACTIVE_LOW>;
> > +		reset-assert-us = <1>;
> > +		reset-deassert-us = <200>;
> > +		interrupt-parent = <&gpio_exp_1v8>;
> > +		interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
> 
> PHY interrupts are generally level not edge. So this is probably
> wrong.

Thanks for the pointer.

> > +		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
> > +		ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> > +		ti,led-function = <0x05b0>;
> > +		ti,led-ctrl = <0x1001>;
> 
> I really would prefer /sys/class/leds was used. In fact, these are not
> documented, and don't even seem to be implemented in mainline. So you
> need to drop them.

Ah, sorry, this slipped in from downstream kernel. Will be removed.

Thanks and best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/