[PATCH v13 1/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver

[yuji2.ishikawa at toshiba.co.jp]

Hello Krzysztof

Thank you for review comments.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: Thursday, October 16, 2025 3:38 PM
> To: ishikawa yuji(石川 悠司 □ＡＩＤＣ○ＥＡ開)
> <yuji2.ishikawa at toshiba.co.jp>; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○
> ＣＰＴ) <nobuhiro.iwamatsu.x90 at mail.toshiba>; Mauro Carvalho Chehab
> <mchehab at kernel.org>; Rob Herring <robh at kernel.org>; Krzysztof Kozlowski
> <krzk+dt at kernel.org>; Conor Dooley <conor+dt at kernel.org>; Philipp Zabel
> <p.zabel at pengutronix.de>
> Cc: linux-media at vger.kernel.org; devicetree at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add
> Toshiba Visconti MIPI CSI-2 Receiver
> 
> On 16/10/2025 04:24, Yuji Ishikawa wrote:
> > Adds the Device Tree binding documentation that allows to describe
> 
> "Add".
> 
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submit
> ting-patches.rst#L94
> 

I'll fix commit messages.

> 
> > the MIPI CSI-2 Receiver found in Toshiba Visconti SoCs.
> 
> 
> ...
> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        csi0: csi at 1c008000 {
> 
> I don't understand why the label appeared. It is not used and it wasn't here
> before. I did not ask to add label, but I only asked to fix the node name to match
> generic names rule.
> 
> Drop the label. With these fixes:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> 

I'll remove the label.

> 
> Best regards,
> Krzysztof

Regards,
Yuji Ishikawa