[PATCH 01/10] lib/crypto: blake2s: Adjust parameter order of blake2s()

Jason A. Donenfeld Jason at zx2c4.com
Sun Oct 19 07:36:36 PDT 2025


On Fri, Oct 17, 2025 at 09:30:57PM -0700, Eric Biggers wrote:
> Reorder the parameters of blake2s() from (out, in, key, outlen, inlen,
> keylen) to (key, keylen, in, inlen, out, outlen).

No objections to putting the size next to the argument. That makes
sense. But the order really should be:

    out, outlen, in, inlen, key, keylen

in order to match normal APIs that output data. The output argument goes
first. The input argument goes next. Auxiliary information goes after.



More information about the linux-arm-kernel mailing list