[PATCH 1/3] PCI: j721e: Propagate dev_err_probe return value

Markus Elfring Markus.Elfring at web.de
Sat Oct 18 03:42:55 PDT 2025


>> I propose to take another source code transformation approach better into account.
>> https://elixir.bootlin.com/linux/v6.17.1/source/drivers/base/core.c#L5031-L5075
>>
>> Example:
>> https://elixir.bootlin.com/linux/v6.17.1/source/drivers/pci/controller/cadence/pci-j721e.c#L444-L636
>>
>>         ret = dev_err_probe(dev, cdns_pcie_init_phy(dev, cdns_pcie), "Failed to init phy\n");
>>         if (ret)
>>                 goto err_get_sync;
>>
> No, the correct code ensures that dev_err_probe() is only called when
> an actual error
> has occurred, providing a clear and accurate log entry. …

Where do you see undesirable technical differences?

Regards,
Markus



More information about the linux-arm-kernel mailing list