[PATCH net v3 2/3] net: stmmac: Consider Tx VLAN offload tag length for maxSDU
G Thomas, Rohan
rohan.g.thomas at altera.com
Fri Oct 17 00:36:34 PDT 2025
Hi All,
On 10/17/2025 11:41 AM, Rohan G Thomas via B4 Relay wrote:
>
> + sdu_len = skb->len;
> /* Check if VLAN can be inserted by HW */
> has_vlan = stmmac_vlan_insert(priv, skb, tx_q);
> + if (has_vlan)
> + sdu_len += VLAN_HLEN;
> +
> + if (priv->est && priv->est->enable &&
> + priv->est->max_sdu[queue] &&
> + skb->len > priv->est->max_sdu[queue]){
I just noticed an issue with the reworked fix after sending the patch.
The condition should be: sdu_len > priv->est->max_sdu[queue]
I’ll send a corrected version, and will wait for any additional comments
in the meantime.
> + priv->xstats.max_sdu_txq_drop[queue]++;
> + goto max_sdu_err;
> + }
>
> entry = tx_q->cur_tx;
> first_entry = entry;
>
Best Regards,
Rohan
More information about the linux-arm-kernel
mailing list