[PATCH v4 3/3] arm64: dts: qcom: monaco-evk-camera: Add DT overlay

[Nihal Kumar Gupta]

On 16-10-2025 00:45, Vladimir Zapolskiy wrote:
>> configuration. Introducing a device tree overlay to support optional
> 
> s/Introducing/Introduce
> 
ACK

>> Co-developed-by: Ravi Shankar <quic_rshankar at quicinc.com>
>> Signed-off-by: Ravi Shankar <quic_rshankar at quicinc.com>
> 
> The first expected Signed-off-by tag shall be from the change author, and
> it is not.
ACK

>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> 
> Year is missing.
> 
This is as per new yearless copyright format.

>> +        avdd-supply = <&vreg_cam1_2p8>;
>> +
> 
> Please remove empty lines between individual properties.
> 
ACK

> Remove 'clock-lanes' property, first of all it is non-configurable,
> and definitely it's hypothetical value can not be equal to '7'.
ACK

>> +        };
> 
> I'd suggest to add a description of pins with MCLK function in a separate
> change to the SoC specific .dtsi file. It will cover gpio67, gpio68, gpio74
> and gpio69, so here it's a MCLK1 pin for instance.
We are currently enabling sensor only on CCI1.  Pins gpio67–gpio69 are used by mclk for cam0–cam2, and gpio74 enables the regulator.
Since mclk is sensor-specific, it's added in the sensor dtso.

Would it be appropriate to extend mclk support to all CCI instances, even if some are not actively used?

@Konrad, @Bryan, Could you please share your thoughts on the above?

If valid, then cam0_default, cam1_default, cam2_default should be added in SoC dtsi, with references used in sensor dtso.

> 
>> +
>> +        ldo-avdd-pins { 

-- 
Regards,
Nihal Kumar Gupta